Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SBT is installed using Coursier #669

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Ensure SBT is installed using Coursier #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d41fa7
Ensure SBT is installed using Coursier
alejandrohdezma Jan 4, 2025
dbefdd4
Remove `setup-sbt` step from examples
alejandrohdezma Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
runs-on: ubuntu-latest
name: Scala Steward
steps:
- name: Install sbt
uses: sbt/setup-sbt@v1
- name: Scala Steward
uses: scala-steward-org/scala-steward-action@v2
```
Expand Down Expand Up @@ -134,8 +132,6 @@ jobs:
runs-on: ubuntu-latest
name: Launch Scala Steward
steps:
- name: Install sbt
uses: sbt/setup-sbt@v1
- name: Launch Scala Steward
uses: scala-steward-org/scala-steward-action@v2
with:
Expand Down Expand Up @@ -333,8 +329,6 @@ You can manually trigger workflow runs using the [workflow_dispatch](https://doc
runs-on: ubuntu-latest
name: Launch Scala Steward
steps:
- name: Install sbt
uses: sbt/setup-sbt@v1
- name: Launch Scala Steward
uses: scala-steward-org/scala-steward-action@v2
with:
Expand Down Expand Up @@ -392,8 +386,6 @@ When using the `github-app-*` inputs, Scala Steward will always retrieve the lis
runs-on: ubuntu-latest
name: Launch Scala Steward
steps:
- name: Install sbt
uses: sbt/setup-sbt@v1
- name: Launch Scala Steward
uses: scala-steward-org/scala-steward-action@v2
with:
Expand Down
6 changes: 4 additions & 2 deletions src/modules/coursier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {type NonEmptyString} from '../core/types'
* Installs `coursier` and add its executable to the `PATH`.
*
* Once coursier is installed, installs `scalafmt`
Copy link
Contributor

@jsoref jsoref Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Once coursier is installed, installs `scalafmt`
* Once coursier is installed, installs `scalafmt`,

* `scalafix` and `scala-cli` tools.
* `scalafix`, `sbt` and `scala-cli` tools.
*
* Throws error if the installation fails.
*/
Expand All @@ -32,7 +32,7 @@ export async function install(): Promise<void> {

await exec.exec(
'cs',
['install', 'scalafmt', 'scalafix', 'scala-cli', '--install-dir', binary],
['install', 'scalafmt', 'scalafix', 'scala-cli', 'sbt', '--install-dir', binary],
{
silent: true,
listeners: {stdline: core.debug, errline: core.debug},
Expand All @@ -51,6 +51,8 @@ export async function install(): Promise<void> {

core.info(`✓ Scalafix installed, version: ${scalafixVersion.trim()}`)

core.info('✓ SBT installed')

core.info('✓ scala-cli installed')
} catch (error: unknown) {
core.debug((error as Error).message)
Expand Down
Loading