Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SBT is installed using Coursier #669

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

alejandrohdezma
Copy link
Member

Fixes #663

github-actions bot added a commit that referenced this pull request Jan 4, 2025
@alejandrohdezma alejandrohdezma force-pushed the fix/ensure-sbt-is-installed branch from a140810 to 89338eb Compare January 4, 2025 11:00
github-actions bot added a commit that referenced this pull request Jan 4, 2025
@alejandrohdezma alejandrohdezma force-pushed the fix/ensure-sbt-is-installed branch from 89338eb to 6648ba3 Compare January 4, 2025 11:06
github-actions bot added a commit that referenced this pull request Jan 4, 2025
Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think then the GHA setp:

       - name: Install sbt
         uses: sbt/setup-sbt@v1

can be removed in the README.md (multiple times)

@alejandrohdezma alejandrohdezma force-pushed the fix/ensure-sbt-is-installed branch from 6648ba3 to 4bec440 Compare January 4, 2025 19:13
github-actions bot added a commit that referenced this pull request Jan 4, 2025
@alejandrohdezma alejandrohdezma force-pushed the fix/ensure-sbt-is-installed branch from 4bec440 to 2d41fa7 Compare January 4, 2025 19:16
github-actions bot added a commit that referenced this pull request Jan 4, 2025
github-actions bot added a commit that referenced this pull request Jan 4, 2025
Copy link
Contributor

github-actions bot commented Jan 4, 2025

A snapshot release has been created as snapshots/669.

You can test it out with:

uses: scala-steward-org/scala-steward-action@snapshots/669

It will be automatically recreated on any change to this PR.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
core 100% 100% 0
modules 69% 88% 0
Summary 70% (495 / 705) 89% (74 / 83) 0

@alejandrohdezma
Copy link
Member Author

alejandrohdezma commented Jan 4, 2025

Thanks @mzuehlke! Just made the change to README. I have tested it on runners with/without SBT pre-installed and it works fine in both of them.

@alejandrohdezma alejandrohdezma merged commit b2ce4e0 into master Jan 4, 2025
2 checks passed
@alejandrohdezma alejandrohdezma deleted the fix/ensure-sbt-is-installed branch January 4, 2025 19:27
@@ -10,7 +10,7 @@ import {type NonEmptyString} from '../core/types'
* Installs `coursier` and add its executable to the `PATH`.
*
* Once coursier is installed, installs `scalafmt`
Copy link
Contributor

@jsoref jsoref Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Once coursier is installed, installs `scalafmt`
* Once coursier is installed, installs `scalafmt`,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action doesn't work on ubuntu-24.04 / ubuntu-latest (when it's ubuntu-24.04) because sbt is missing
3 participants