-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[githubgen] PR feedback follow-ups #655
base: main
Are you sure you want to change the base?
[githubgen] PR feedback follow-ups #655
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 48.86% 50.19% +1.32%
==========================================
Files 57 57
Lines 3381 3405 +24
==========================================
+ Hits 1652 1709 +57
+ Misses 1568 1534 -34
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
19d4bae
to
d10937e
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
…rimming configurable Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
d10937e
to
0196800
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to look into some files, but some small comments
# List of components in %s | ||
# waiting on owners to be assigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid having to plumb the pretty repo name through, we could just get rid of it. For example, here we could put:
# List of components in %s | |
# waiting on owners to be assigned | |
# List of components waiting on owners to be assigned |
# | ||
# Learn about membership in OpenTelemetry community: | ||
# https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OpenTelemetry specific, but we let people specify a different Github org. We should either remove it:
# | |
# Learn about membership in OpenTelemetry community: | |
# https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md | |
# |
or hardcode the Github org
# | ||
# Learn about membership in OpenTelemetry community: | ||
# https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
# | |
# Learn about membership in OpenTelemetry community: | |
# https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md | |
# |
This PR
versions.yaml