Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.16.0 #656

Closed

Conversation

jade-guiton-dd
Copy link
Contributor

v0.16.0

🚀 New components 🚀

💡 Enhancements 💡

@jade-guiton-dd jade-guiton-dd requested review from a team as code owners January 7, 2025 14:27
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.86%. Comparing base (3f22feb) to head (ebdd377).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          57       57           
  Lines        3381     3381           
=======================================
  Hits         1652     1652           
  Misses       1568     1568           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 7, 2025
@MrAlias
Copy link
Contributor

MrAlias commented Jan 7, 2025

There is follow up underway to this new component: #655

This release seems premature.

@mx-psi
Copy link
Member

mx-psi commented Jan 7, 2025

@MrAlias I think @jade-guiton-dd is interested in releasing #642, not the githubgen changes. I guess we could temporarily revert #639, do the release, then apply #639 again?

@mowies
Copy link
Member

mowies commented Jan 7, 2025

It should be fine to release even with githubgen. the tool works as is for open-telemetry/opentelemetry-collector-contrib, just not for other use cases. That's what the follow up PR is for.
Either way, the tool is not used anywhere as a dependency yet, so it should be fine as is as well.

@mx-psi mx-psi requested a review from MrAlias January 7, 2025 16:07
@jade-guiton-dd
Copy link
Contributor Author

Yes, I was hesitating to do a release because of the follow up PR. It sounds like it should be okay, but we can delay the release if you feel it necessary. I could use a pseudo-version on contrib in the meantime to start integrating #642.

@MrAlias
Copy link
Contributor

MrAlias commented Jan 7, 2025

I feel we need to revert prior to a release given approvals for #639 were made with the assumption that things would be fixed.

@dmathieu
Copy link
Member

dmathieu commented Jan 8, 2025

Couldn't we just remove it from versions.yaml so it's not released rather than a full revert?

@jade-guiton-dd
Copy link
Contributor Author

@dmathieu I can try doing a partial release with only crosslink. Has that been done before?

@dmathieu
Copy link
Member

dmathieu commented Jan 8, 2025

I believe that would require doing the release manually, which doesn't look like a good idea.

@jade-guiton-dd
Copy link
Contributor Author

I'll try the release again excluding just githubgen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants