Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: do not use common.isMainThread #56768

Merged
merged 1 commit into from
Jan 26, 2025
Merged

test: do not use common.isMainThread #56768

merged 1 commit into from
Jan 26, 2025
+2 −1

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 26, 2025 •
edited
Loading

common.isMainThread was removed in
8caa1dcee63b2c6fd7a9, use the
isMainThread export of the worker_threads module instead.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2025
@lpinca lpinca changed the title test: use worker.isMainThread instead of common.isMainThread test: do not use common.isMainThread Jan 26, 2025
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@lpinca
test: do not use common.isMainThread
70d4d2e 
`common.isMainThread` was removed in
nodejs@8caa1dcee63b2c6fd7a9, use the
`isMainThread` export of the `worker_threads` module instead.
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (7119303) to head (70d4d2e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56768      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.01%     
==========================================
  Files         662      662              
  Lines      192125   192125              
  Branches    36972    36981       +9     
==========================================
- Hits       171421   171411      -10     
- Misses      13543    13546       +3     
- Partials     7161     7168       +7

see 31 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64755/

@legendecas legendecas mentioned this pull request Jan 26, 2025
Merged
@legendecas legendecas mentioned this pull request Jan 26, 2025
Open
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 26, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64757/

mcollina
mcollina approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64758/

@cjihrig cjihrig mentioned this pull request Jan 26, 2025
Open
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit 80c70ee into nodejs:main Jan 26, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 80c70ee

@lpinca lpinca deleted the fix/failing-test branch January 26, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @nodejs-github-bot @mcollina @jasnell @targos @legendecas