Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain API E2E Test: wallet_revokeSession #29639

Open
wants to merge 9 commits into
base: jl/caip-multichain-migrate-core
Choose a base branch
from

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Jan 10, 2025

-- test: multichain test dapp wallet_revokeSession e2e tests

NOTE: test-e2e-chrome-flask pipeline should pass after wallet_invokeMethod e2e tests are merged

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ffmcgee725 ffmcgee725 force-pushed the jc/wallet_revokeSession-test-dapp-e2e branch from 32f8f5f to 4039417 Compare January 10, 2025 18:41
@ffmcgee725 ffmcgee725 requested review from adonesky1 and jiexi January 10, 2025 18:42
actualError[key],
`calling wallet_invokeMethod should throw an error with ${key} ${value} for scope ${scope}`,
);
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally in this section I'd prefer something along the lines of

expect(actualError).toBeEqual(expect.objectContaining(expectedError))

Which jest's API allows me to do, but node's strict doesn't seem to have a similar feature. Open to suggestion on a cleaner way of asserting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants