-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain API E2E Test: wallet_revokeSession #29639
base: jl/caip-multichain-migrate-core
Are you sure you want to change the base?
Multichain API E2E Test: wallet_revokeSession #29639
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
32f8f5f
to
4039417
Compare
actualError[key], | ||
`calling wallet_invokeMethod should throw an error with ${key} ${value} for scope ${scope}`, | ||
); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally in this section I'd prefer something along the lines of
expect(actualError).toBeEqual(expect.objectContaining(expectedError))
Which jest's API allows me to do, but node's strict doesn't seem to have a similar feature. Open to suggestion on a cleaner way of asserting here.
-- test: multichain test dapp wallet_revokeSession e2e tests
NOTE:
test-e2e-chrome-flask
pipeline should pass after wallet_invokeMethod e2e tests are mergedDescription
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist