-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain API E2E Test: wallet_notify #29623
Multichain API E2E Test: wallet_notify #29623
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Could we rename the test file to |
Builds ready [38c9ead]
Page Load Metrics (1721 ± 75 ms)
|
/** | ||
* Currently we don't have `data-testid` setup for the desired result, so we click on all available results | ||
* to make the complete text available and later evaluate if scopes match. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can use css to hide the extra text rather than adding and removing it from the DOM
@adonesky1 I change file name on this one so Jiexi doesn't need to re-approve 👍🏾 |
c4b62c1
into
jl/caip-multichain-migrate-core
-- test: multichain test dapp e2e test for wallet_notify
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist