Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain API E2E Test: wallet_notify #29623

Merged

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Jan 10, 2025

-- test: multichain test dapp e2e test for wallet_notify

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ffmcgee725 ffmcgee725 requested a review from jiexi January 10, 2025 16:17
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 1.69 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@ffmcgee725 ffmcgee725 requested a review from adonesky1 January 10, 2025 16:52
@adonesky1
Copy link
Contributor

adonesky1 commented Jan 10, 2025

Could we rename the test file to wallet_notify.spec.ts ?

@metamaskbot
Copy link
Collaborator

Builds ready [38c9ead]
Page Load Metrics (1721 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40920651655331159
domContentLoaded14931995170615675
load15042006172115675
domInteractive2384452210
backgroundConnect94819115
firstReactRender17101462813
getState460182110
initialActions01000
loadScripts10531536125414871
setupStore682192311
uiStartup169225752027217104

Comment on lines +45 to +48
/**
* Currently we don't have `data-testid` setup for the desired result, so we click on all available results
* to make the complete text available and later evaluate if scopes match.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can use css to hide the extra text rather than adding and removing it from the DOM

@ffmcgee725
Copy link
Member Author

@adonesky1 I change file name on this one so Jiexi doesn't need to re-approve 👍🏾

@ffmcgee725 ffmcgee725 merged commit c4b62c1 into jl/caip-multichain-migrate-core Jan 10, 2025
70 of 72 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/wallet_notify-test-dapp-e2e branch January 10, 2025 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants