adding reverse resolver fetch when graph fails to retreive ens name #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue
#1731
Changes
This solution works, I am not sure if it is the right solution though. I spent some time in the ens subgraph trying to grab this information but I was not able to. It turns out @scottrepreneur opened a pr for this on there subgraph a while ago
pr link
issue link
I can pick that subgraph pr up and we can attempt to fix it that way depending on what we want to do here
Packages Added
eth-ens-namehash - adding normalize check as recommended by ens docs
Checks
Before making your PR, please check the following:
Details
you can see the call return the right address in this console log:
null
for thereverseRegistations
(ie 0 length)