Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding reverse resolver fetch when graph fails to retreive ens name #1836

Merged
merged 3 commits into from
May 23, 2022

Conversation

brossetti1
Copy link
Contributor

@brossetti1 brossetti1 commented May 20, 2022

GitHub Issue

#1731

Changes

  • added a backup contract call to the reverse records to ensure that eth name is retrieved.

This solution works, I am not sure if it is the right solution though. I spent some time in the ens subgraph trying to grab this information but I was not able to. It turns out @scottrepreneur opened a pr for this on there subgraph a while ago
pr link
issue link

I can pick that subgraph pr up and we can attempt to fix it that way depending on what we want to do here

Packages Added

eth-ens-namehash - adding normalize check as recommended by ens docs

Checks

Before making your PR, please check the following:

  • Critical lint errors are resolved
  • App runs and builds locally

Details

you can see the call return the right address in this console log:

  1. graph is called which returns null for the reverseRegistations (ie 0 length)
  2. contract is called which correctly identifies the ens name (hardcoded griffs address in the actual console.log on my local environment)

Screen Shot 2022-05-20 at 3 51 59 PM

Screen Shot 2022-05-20 at 3 54 27 PM

@brossetti1 brossetti1 marked this pull request as ready for review May 20, 2022 22:41
@plor plor linked an issue May 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ENS not appearing for everyone
2 participants