Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ENS not appearing for everyone #1731

Closed
peth-yursick opened this issue Mar 22, 2022 · 4 comments · Fixed by #1836
Closed

Bug: ENS not appearing for everyone #1731

peth-yursick opened this issue Mar 22, 2022 · 4 comments · Fixed by #1836
Assignees
Labels
bug Something isn't working

Comments

@peth-yursick
Copy link

Looks like ENS domains are not appearing for everyone.

For most people, setting ENS as their primary in the ENS dashboard makes their primary ENS appear instead of their hex address in DAOhaus & Yeeter.

Worked for me, but not for Griff.
He had it set from before:
image
Yet still not appearing:
image
Link to the yeeter if anybody wants to go check it out

I messaged Dekan to see if there's anything else that people need to do besides setting as primary & he told me someone else had this problem before.

Idk how rare this problem is but might be worth further investigation.

@skuhlmann skuhlmann moved this to Needs Triage in DAOhaus v2: Robot Apartments Apr 12, 2022
@skuhlmann skuhlmann added the bug Something isn't working label Apr 13, 2022
@plor
Copy link
Contributor

plor commented May 18, 2022

I ran this query directly on the subgraph and was able to reproduce this for griff.eth. I don't know if there is a point before which the reverse record was set up where the event doesn't make it to this subgraph. It may be helpful to find a different subgraph that could achieve this same thing (use official ENS subgraph?) and see if this is more robust.

@plor plor changed the title ENS not appearing for everyone Bug: ENS not appearing for everyone May 18, 2022
@plor plor moved this from Needs Triage to Ready For Dev in DAOhaus v2: Robot Apartments May 18, 2022
@brossetti1
Copy link
Contributor

hey @plor @peth-yursick I implemented a fix for this, wondering if someone can provide feedback on if this is the right solution (see changes section for details)

@plor
Copy link
Contributor

plor commented May 20, 2022

Thanks @brossetti1! I'll add you to this bug and move it into testing. I can take a look, but I think @skuhlmann or @scottrepreneur will be able to comment better on the change.

@plor plor moved this from Ready For Dev to Testing in DAOhaus v2: Robot Apartments May 20, 2022
@plor
Copy link
Contributor

plor commented May 20, 2022

fixed by #1836 (figuring out how to link them, btw this didn't work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants