Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authors list base on contributor stats. #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BigBlueHat
Copy link
Member

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to just say "lgtm", but I realized that the stats page counts commits.

Any given commit could include 1 or 1000 (or more) lines of source.

A one-commit user could "author" an entire document of 1000 lines, against which some enterprising reviewers could make 100 one-line PRs, or one 100-line PR against which some other(s) could make several 1-line change requests.

The sum total of these contributions could easily put the contributor of 100 one-line PRs ahead in the "commit" count — but they should not be ranked as more of an author than the original 1000-line committer who never added another.

It doesn't appear to me that GitHub statistics handle things in a useful fashion for this use.

@BigBlueHat
Copy link
Member Author

It doesn't appear to me that GitHub statistics handle things in a useful fashion for this use.

Agreed. I didn't blindly list whomever was in the list. There were cases where I (for example) had added loads of content/commits to setup the OSS licensing...but made no real substantial "authoring" changes to the test suite code/material.

The lists I did post here are (afaict) accurately considerable as "authors" of the test suites. That said, I do need to add @Wind4Greg to some of the suites as his test vectors were used--even though he didn't make the commits.

@TallTed the goal of this was to make things more accurate from how they had been before (and to cite my source). It could certainly till use work, so if/when you see a need for other authors to be added, please feel free to send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants