Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Merge bitsandbytes_stacked_params_mapping and packed_modules_mapping #11924

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jan 10, 2025

They can be converted between each other. We can remove bitsandbytes_stacked_params_mapping and convert packed_modules_mapping to achieve the functionality of bitsandbytes_stacked_params_mapping, thereby further cleaning up the model's static variables

TODO

  • delete bitsandbytes_stacked_params_mapping from all models

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee marked this pull request as draft January 10, 2025 10:22
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin self-requested a review January 10, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant