Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed print.h and print.c #8

Merged
merged 2 commits into from
May 17, 2024
Merged

Fixed print.h and print.c #8

merged 2 commits into from
May 17, 2024

Conversation

wwidlishy
Copy link
Contributor

print.h

  • Modified VGA_WIDTH from 25 to 80
  • Modified VGA_HEIGHT from 80 to 25

print.c

  • Fixed handle_new_line() to handle '\n' correctly

wwidlishy added 2 commits May 17, 2024 13:19
@wwidlishy
Add files via upload
30e3a54
@wwidlishy
Print.h and Print.c fixes
d4bd466 
print.h:
- swapped VGA_WIDTH & VGA_HEIGHT for the correct values

print.c:
- fixed handle_next_line() to correctly handle the new line character.
github-actions[bot]
github-actions bot reviewed May 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thank you for contributing your first pull request to NoobOS.

@vinsdragonis vinsdragonis merged commit e4c6516 into vinsdragonis:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwidlishy @vinsdragonis