-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up builds on travis #384
base: master
Are you sure you want to change the base?
Conversation
This way travis gives a better indication which command failed. Also it makes the lines shorter and easier to read.
The gem is used to interact with travis.ci which is not strictly necessary to test vdebug (even if the tests run on travis). This also makes some dependencies obsolete as they where only needed for the travis gem.
This makes sudo and the setup of sudo unnecessary.
Apt needs a special environment variable to work but the other commands do not need a tty.
The ruby specs in spec/startup_spec.rb fail randomly on travis so we execute the specs separated from the feature tests. That way rake will not stop after the failure.
The package installation with bundler does not require a full login session from su so it can be run with sh.
Further answers about the travis build:
Answers to questions about the tests (in general and on travis):
|
I started to play around with this again. What motivated me where some changes from travis' side: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration If we want to run tests on OSX we will not be able to use python:
- "3.4"
- "3.5"
# ... But which might still be interesting as it should start a different VM with that python version preinstalled so the I think we have to decide between two options:
@BlackIkeEagle What do you think? What might be more important to test regarding frequent bug reports? |
I cleaned up and commented the travis file. Results:
docker exec --tty
)locale-gen
andsu
Further questions about the travis build:
Questions about the tests (in general and on travis):