Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-RFC for increased availability of NUMA API #1545

Conversation

aleksei-fedotov
Copy link
Contributor

Description

Add sub-RFC to #1535 for increased availability of NUMA API.

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small wording issues.

@aleksei-fedotov aleksei-fedotov force-pushed the dev/aleksei-fedotov/rfc_numa_support-increased-availability branch from 83b8788 to 5e8b79e Compare November 14, 2024 09:27
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this proposal.


Having a dependency on a shared HWLOC library has advantages:
1. Code reuse with all of the positive consequences out of this, including
relying on the same code that has been tested and debugged, allowing the OS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in fact most of Linux OSes has obsolete hwloc versions and relying on it does not provide benefits.
IMO, having most up-to-date static HWLOC together with recent versions of oneTBB has benefits and fixes / new features are available to oneTBB immediately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did not know that. I will consider this in the future changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rewrite it to smth like this:
1. Reliability. Using a tested and debugged shared library, oneTBB benefits from established, reliable functionality.
2. Code Reuse. Reuse the same code across different processes, improving cache locality and reducing memory footprint, which is the primary purpose of shared libraries.
3. Drop-In Replacement. Use your version of HWLOC without recompiling oneTBB. It can be useful in the following cases:

  • You need to apply a hotfix to support your hardware that has not yet been integrated into the HWLOC project.
  • You use a HWLOC version that may never be upstreamed. For example, if hardware unavailable to the broader market.
  • You want to test a development version of HWLOC on your system.

rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
@vossmjp vossmjp added the RFC label Jan 9, 2025
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
refuse working requiring one of the ~tbbbind~ variant to be loaded (e.g., throw
an exception).

Comparing these alternative approaches to the one proposed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No necessarily.

rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org Outdated Show resolved Hide resolved
@aleksei-fedotov aleksei-fedotov merged commit 91ca50b into dev/vossmjp/rfc_numa_support Jan 23, 2025
1 check passed
@aleksei-fedotov aleksei-fedotov deleted the dev/aleksei-fedotov/rfc_numa_support-increased-availability branch January 23, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants