-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub-RFC for increased availability of NUMA API #1545
Add sub-RFC for increased availability of NUMA API #1545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small wording issues.
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Voss <[email protected]>
83b8788
to
5e8b79e
Compare
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this proposal.
|
||
Having a dependency on a shared HWLOC library has advantages: | ||
1. Code reuse with all of the positive consequences out of this, including | ||
relying on the same code that has been tested and debugged, allowing the OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but in fact most of Linux OSes has obsolete hwloc versions and relying on it does not provide benefits.
IMO, having most up-to-date static HWLOC together with recent versions of oneTBB has benefits and fixes / new features are available to oneTBB immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I did not know that. I will consider this in the future changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rewrite it to smth like this:
1. Reliability. Using a tested and debugged shared library, oneTBB benefits from established, reliable functionality.
2. Code Reuse. Reuse the same code across different processes, improving cache locality and reducing memory footprint, which is the primary purpose of shared libraries.
3. Drop-In Replacement. Use your version of HWLOC without recompiling oneTBB. It can be useful in the following cases:
- You need to apply a hotfix to support your hardware that has not yet been integrated into the HWLOC project.
- You use a HWLOC version that may never be upstreamed. For example, if hardware unavailable to the broader market.
- You want to test a development version of HWLOC on your system.
Co-authored-by: Alexandra <[email protected]>
refuse working requiring one of the ~tbbbind~ variant to be loaded (e.g., throw | ||
an exception). | ||
|
||
Comparing these alternative approaches to the one proposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No necessarily.
Description
Add sub-RFC to #1535 for increased availability of NUMA API.
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information