-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pglite): use async init #130
Conversation
The mention in the Got a new keyboard now 😬 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage ? 42.32%
=======================================
Files ? 22
Lines ? 860
Branches ? 89
=======================================
Hits ? 364
Misses ? 492
Partials ? 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (made few changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (made few changes)
Proposed in sandros94/nuxt-pglite#7, these changes improve typing for newly created PGlite instance that do have extensions added.
This also make sure that the PGlite instance is ready before executing any query (
.create
internally also awaits for.waitReady
).I've also changed the following default because in rare occasions PGlite forcefully tries to find
params
in an empty array, hanging without notice: