Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User invite email fails if visited more than once without completing #17901

Open
wants to merge 1 commit into
base: v13/contrib
Choose a base branch
from

Conversation

dchallener
Copy link
Contributor

#17681

This PR looks to reset the security stamp back to previous when doing the signin behind the scenes in the same way lastlogindate is being reset. This allows the action to happen again until the user completes the process.

Copy link

github-actions bot commented Jan 6, 2025

Hi there @dchallener, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @dchallener ,

Thanks for your PR to implement #17681, and stop the user invite email failing if it is visited > once without completing.

One of the Core Collaborators team will review this as soon as possible - it also seems like one that we want HQ to review, so I'll contact them about it.

Best wishes

Emma

@dchallener
Copy link
Contributor Author

Thanks @emmagarland ,

Let me know if there is anything else required in the meantime. Would be super great to get this into an upcoming release as is causing us issues with clients using mail scanners or link checkers.

Best wishes,
David

@emmagarland
Copy link
Contributor

@dchallener thanks David, we're currently in discussion with HQ about this as it might be some surrounding code needs tweaking. I'll let you know as soon as we have a decision on the best approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants