-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Umbraco Package Schema and custom-elements to root level #17866
base: contrib
Are you sure you want to change the base?
Conversation
…o be placed at root level, add generation to build for npm and update .gitignore
Hi there @korbi551, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @korbi551 , Thank you for taking the time to look into this one! 🙌 |
@@ -149,7 +149,7 @@ | |||
"backoffice:test:e2e": "npx playwright test", | |||
"build-storybook": "npm run wc-analyze && storybook build", | |||
"build:for:cms": "npm run build && npm run build:workspaces && npm run generate:manifest && npm run package:validate && node ./devops/build/copy-to-cms.js", | |||
"build:for:npm": "npm run build -- --declaration && npm run generate:manifest && npm run package:validate", | |||
"build:for:npm": "npm run build -- --declaration && npm run generate:manifest && npm run package:validate && npm run generate:jsonschema:dist && npm run wc-analyze", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add the generation here as that is already being done in the prepack step:
"build:for:npm": "npm run build -- --declaration && npm run generate:manifest && npm run package:validate && npm run generate:jsonschema:dist && npm run wc-analyze", | |
"build:for:npm": "npm run build -- --declaration && npm run generate:manifest && npm run package:validate", |
@@ -103,6 +103,7 @@ tools/docfx/ | |||
/src/Umbraco.Web.UI/appsettings-schema.json | |||
/src/Umbraco.Web.UI/appsettings-schema.*.json | |||
/src/Umbraco.Web.UI/umbraco-package-schema.json | |||
/src/Umbraco.Web.UI.Client/umbraco-package-schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to the local .gitignore
file inside the Client folder. Please also verify if the file custom-elements.json
is properly ignored.
Prerequisites
Fixes #16667
Description
According to the problem, the generation of the json schema and the user-defined elements was moved to the root level. The wc-analyze and generate:jsonschema:dist scripts have therefore been changed and added to build:for:npm.
Unfortunately I could not determine if changing the scripts causes problems.