chore: Verify if scrape definition is created correctly (#1381)

Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove · Nov 26, 2020 · 011c57c · 011c57c
1 parent 746622d
commit 011c57c
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/Promitor.Core.Scraping/Configuration/Model/Metrics/MetricDefinition.cs b/src/Promitor.Core.Scraping/Configuration/Model/Metrics/MetricDefinition.cs
@@ -60,14 +60,18 @@ public MetricDefinition(PrometheusMetricDefinition prometheusMetricDefinition,
         /// <returns>The scrape definition.</returns>
         public ScrapeDefinition<IAzureResourceDefinition> CreateScrapeDefinition(IAzureResourceDefinition resource, AzureMetadata azureMetadata)
         {
-            // TODO: Verify if this logic is valid as we always use defaults? 🤔
-            return new ScrapeDefinition<IAzureResourceDefinition>(
+            var subscriptionId = string.IsNullOrEmpty(resource.SubscriptionId) ? azureMetadata.SubscriptionId : resource.SubscriptionId;
+            var resourceGroupName = string.IsNullOrEmpty(resource.ResourceGroupName) ? azureMetadata.ResourceGroupName : resource.ResourceGroupName;
+
+            var output =  new ScrapeDefinition<IAzureResourceDefinition>(
                 AzureMetricConfiguration,
                 PrometheusMetricDefinition,
                 Scraping,
                 resource,
-                string.IsNullOrEmpty(resource.SubscriptionId) ? azureMetadata.SubscriptionId : resource.SubscriptionId,
-                string.IsNullOrEmpty(resource.ResourceGroupName) ? azureMetadata.ResourceGroupName : resource.ResourceGroupName);
+                subscriptionId,
+                resourceGroupName);
+
+            return output;
         }
     }
 }