build: update windows-sys to 0.59.0

[ErichDonGubler]

Carries on the effort from #1820, with some fixes that should make tests compile now.

[Darksonn]

Which field in Inner is making this necessary?

[Darksonn]

It may make more sense to implement these traits for Inner instead, or to wrap the offending field in a newtype and implement them on that newtype.

[ErichDonGubler]

Which field in Inner is making this necessary?

We need to implement Send and Sync manually because HANDLE is no longer considered thread-safe. I think your instinct is right, and we need to capture the overlapped I/O contract with types ourselves now.

Will take some time to dig into that contract, and report what I learn here.

[Darksonn]

This change seems unrelated to the windows-sys upgrade.

[ErichDonGubler]

You are right, but these changes are imposed by CI that runs on this PR. These (and other) changes were made to satisfy clippy, which returns an error unless these changes are made.

I was hoping that having these as separate commits made that clear. 😅 I know that commit structure isn't always useful to consult, though.

[Darksonn]

There's a build failure.

     Checking mio v1.0.3 (D:\a\mio\mio)
  error[E0425]: cannot find function `null_mut` in this scope
    --> src\sys\windows\afd.rs:69:13
     |
  69 |             null_mut(),
     |             ^^^^^^^^ not found in this scope
     |
  help: consider importing this function
     |
  1  + use std::ptr::null_mut;
     |

[ErichDonGubler]

@Darksonn:

There's a build failure.

     Checking mio v1.0.3 (D:\a\mio\mio)
  error[E0425]: cannot find function `null_mut` in this scope
    --> src\sys\windows\afd.rs:69:13
     |
  69 |             null_mut(),
     |             ^^^^^^^^ not found in this scope
     |
  help: consider importing this function
     |
  1  + use std::ptr::null_mut;
     |

Ah, that was an interesting feature combination that I had to use to reproduce locally. 😅 Glad CI caught it!