fix: avoid duplicate pages information #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use set and then convert back to list in order to avoid duplicate page message
tldr.py
Outdated
| @@ -205,7 +205,7 @@ def get_platform() -> str: | |||
|
|
|||
|
|
|||
| def get_platform_list() -> List[str]: | |||
| platforms = ['common'] + list(OS_DIRECTORIES.values()) | |||
| platforms = ['common'] + list(set(list(OS_DIRECTORIES.values()))) | |||
There was a problem hiding this comment.
Suggested change
| platforms = ['common'] + list(set(list(OS_DIRECTORIES.values()))) | |
| platforms = ['common'] + list(set(OS_DIRECTORIES.values())) |
Have you tried like this?
There was a problem hiding this comment.
Have you tried like this?
It doesn't work because we can't concatenate set and list with the plus operator (+), so we need to cast it back to a list. We can however skip the inner conversion:
['common']+list(set(OS_DIRECTORIES.values()))
so we go from dict_values to set to list, and we gain one step 8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix issue #264