Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outliner: Do not outline if the BridgedArg value is not available at the BridgedCall #78581

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Jan 11, 2025

While outlining, if the BridgedArg value's is not available at the BridgedCall, bailout instead of creating a copy.

Fixes rdar://142633893

…the BridgedCall

Avoid outlining this scenario instead of creating a copy to make the value available
This copy may remain unoptimized, avoid outlining this case.
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta
Copy link
Contributor Author

@swift-ci apple silicon benchmark

@meg-gupta meg-gupta marked this pull request as ready for review January 13, 2025 00:43
@meg-gupta meg-gupta requested a review from eeckstein as a code owner January 13, 2025 00:43
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meg-gupta meg-gupta merged commit 1573344 into swiftlang:main Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants