SILGen: Coordinate access strategy determination with actual codegen in findStorageReferenceExprForMoveOnly.
#78572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in `findStorageReferenceExprForMoveOnly`. Looking at the AST-level `getReadImpl` doesn't always correspond to what accessor SILGen prefers to use, due to resilience, ABI rules, and other concerns. In findStorageReferenceExprForMoveOnly, when determining whether a storage reference is borrowable, use the same logic as SILGenLValue actually uses to determine what storage or accessor access strategy to use. Fixes rdar://142509673
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the AST-level
getReadImpldoesn't always correspond to what accessor SILGen prefers to use, due to resilience, ABI rules, and other concerns. In findStorageReferenceExprForMoveOnly, when determining whether a storage reference is borrowable, use the same logic as SILGenLValue actually uses to determine what storage or accessor access strategy to use.Fixes rdar://142509673