[Swiftify] Add return pointer support #78571
Open
+412
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of simply passing a parameter index to _SwiftifyInfo, the _SwiftifyExpr enum is introduced. It currently has two cases: - .param(index: Int), corresponding to the previous parameter index - .return, corresponding to the function's return value. ClangImporter is also updated to pass this new information along to _SwiftifyImport, allowing overloads with buffer pointer return types to be generated. The swiftified return values currently return Span when the return value is marked as nonescaping, despite this not being sound. This is a bug that will be fixed in the next commit, as the issue is greater than just for return values.
There was an assumption that all converted pointers were either converted to Span-family pointers, or UnsafeBufferPointer-family pointers. This was not consistently handled, resulting in violating the `assert(nonescaping)` assert when the two were mixed. This patch removes the Variant struct, and instead each swiftified pointer separately tracks whether it should map to Span or UnsafeBufferPointer. This also fixes return pointers being incorrectly mapped to Span when marked as nonescaping.
hnrklssn
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
a team,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply passing a parameter index to _SwiftifyInfo, the _SwiftifyExpr enum is introduced. It currently has two cases:
ClangImporter is also updated to pass this new information along to _SwiftifyImport, allowing overloads with buffer pointer return types to be generated. The swiftified return values may not yet map to Span types, because we don't currently track the lifetime information necessary to do so.
This also fixes a bug in the decision making for picking the swiftified type, where all pointers would map to [Mutable][Raw]Span when any pointer was marked nonescaping. This is incorrect both for the case where a nonescaping parameter is combined with an escaping parameter, as well as for return values, where being marked as nonescaping is not enough to soundly use Span-types.