Don't look through ownership instructions during CSE #78558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
OSSA rauw creates copies in a lot of cases. Several of these copies cannot be eliminated due to escapes, unimplemeneted optimization edge cases etc. This can be an issue for performance parity with non-ossa Disable looking through ownership instructions to avoid copies created by OSSA rauw. This can be revisited if we rewrite OSSA rauw to not create copies. This has no effect on microbenchmarks with -enable-ossa-modules on by default. rdar://139773406
meg-gupta
force-pushed
the
cseavoidlookthrough
branch
from
f9398c2 to
1c153ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSSA rauw creates copies in a lot of cases. Several of these copies cannot be eliminated due to escapes, unimplemeneted optimization edge cases etc.
This can be an issue for performance parity with non-ossa
Disable looking through ownership instructions to avoid copies created by OSSA rauw.
This can be revisited if we rewrite OSSA rauw to not create copies.
This has no -ve effect on microbenchmarks with -enable-ossa-modules on by default.
rdar://139773406