Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluelight widget #463

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

VMatt013
Copy link

@VMatt013 VMatt013 commented Jan 8, 2025

I created a widget to use blue light filter, and I would like to give the community back something, so here it is
(This is my first PR so if I made any mistakes I am sorry)

@VMatt013 VMatt013 requested a review from streetturtle as a code owner January 8, 2025 13:15
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jan 8, 2025

Oh nice! Redshift 😻

Do you happen to omit -l LON:LAT as CLI argument by accident?

I mean, there's a redshift.conf file that could be defined, too.


local ICON_DIR = gfs.get_configuration_dir() .. "awesome-wm-widgets/bluelight-widget/"
local DAY_ICON = ICON_DIR .. "sun.svg"
local NIGHT_ICON = ICON_DIR .. "moon.svg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, given that these are white, I wonder how they work on a light theme.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just recolored them to white for myself, but not sure what is the usual approach, I found the gears.recolor_image which I never saw or used, or I could just include a "dark" and "light" version of the icons and have a config variable for it

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jan 8, 2025

Do you have plans to include a screenshot?

Even if there's not much to see some widgets still have one.

@VMatt013
Copy link
Author

VMatt013 commented Jan 8, 2025

I tried some stuff to get a screenshot, but nothing captured it, so I have no clue what to use, but if you have any idea i would do it happily

@VMatt013
Copy link
Author

VMatt013 commented Jan 8, 2025

And about the config file, I don't have any, so I think it should work fine

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jan 8, 2025

I love Flameshot for making screenshots.

@VMatt013
Copy link
Author

VMatt013 commented Jan 8, 2025

I use KDE's Spectacle, but it does not capture the effect itself, but the I can and will include a screenshot of the widget itself, you are totally right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants