Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add graphQL landingPage config #2343

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

enhancement: add graphQL landingPage config #2343

wants to merge 9 commits into from

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Jan 9, 2025 •
edited
Loading

What does it do?

  • Adds the graphql landingPage config option
  • renames "playground" to sandbox/landing page. "landing page" is what Apollo calls whatever page is shown at the base url, and "graphql sandbox" is the particular landing page that it (and Strapi) uses by default.

Why is it needed?

"playground" is no longer the correct term in Apollo Server v4 (used in Strapi v5)

Related issue(s)/PR(s)

strapi/strapi#22285

NOTE: this should be published at the same time as next week's release (probably 5.7.1)

@innerdvations innerdvations requested a review from pwizla as a code owner January 9, 2025 12:14
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 3:39pm

@innerdvations innerdvations changed the title enhancement: add landingPage config enhancement: add graphQL landingPage config Jan 9, 2025
@innerdvations
Copy link
Collaborator Author

@pwizla Could I leave you in charge of cleaning up or adding any wording or formatting?

DX will test the examples and make sure those are ok.

pwizla
pwizla approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you, Ben. I fixed a few things, incl. the broken anchors that were preventing the build.

@pwizla pwizla self-assigned this Jan 10, 2025
@pwizla pwizla added this to the 5.5.2 milestone Jan 10, 2025
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: updated content PRs updating existing documentation content labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

@pwizla pwizla pwizla approved these changes

@butcherZ butcherZ Awaiting requested review from butcherZ

@Bassel17 Bassel17 Awaiting requested review from Bassel17

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@pwizla pwizla

Labels
pr: updated content PRs updating existing documentation content source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@innerdvations @pwizla @derrickmehaffy