Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check): correct diagnostic count #61

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Jan 23, 2025

Describe the problem or feature in addition to a link to the issues.

Fixes diagnostic counting that I messed up in #59

Without this fix, "suppressed" Notes and Warnings will be counted and can lead to a confusing exit message.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).

@a-frantz a-frantz self-assigned this Jan 23, 2025
@a-frantz a-frantz requested a review from claymcleod January 23, 2025 20:31
src/commands/check.rs Outdated Show resolved Hide resolved
@a-frantz
Copy link
Member Author

@peterhuene I goofed up in the last few PRs forgetting to update the CHANGELOG. I can cherrypick the commit I made on this branch into a separate PR if we want? Not sure how strict we want to be about the git history.

@a-frantz a-frantz requested a review from peterhuene January 23, 2025 20:51
@peterhuene
Copy link
Collaborator

@a-frantz I think it's fine to fix it as part of this PR.

CHANGELOG.md Outdated Show resolved Hide resolved
@a-frantz a-frantz merged commit fe94d12 into main Jan 23, 2025
8 checks passed
@a-frantz a-frantz deleted the fix/diagnostic-counting branch January 23, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants