-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-show-gt enhancement #2
Open
mvaldman
wants to merge
25
commits into
matrix6-beta
Choose a base branch
from
master
base: matrix6-beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lisation function, tag 2.0.8
jasonm4130
force-pushed
the
master
branch
5 times, most recently
from
February 15, 2024 05:54
c34432d
to
f0cf07d
Compare
fix: Update bct.scss to allow showing of use default toggle in M6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the behaviour of the data-show-gt example doesn't behave as expected.
The example used this metaData keyword to show a number of items
%asset_metadata_amount%
, where the amount is a number.I would expect that if the amount is say 3, then 3 items would then be displayed but due to the CSS only the item with attribute
data-show-gt="3"
actually gets displayed.my work-around is to add this css to
bct.css
, I've also extended it to accomodate up to 15 items.