Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip 001-spin-kube-doctor.md #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajatjindal
Copy link
Member

This PR adds the proposal for adding a subcommand to spin kube plugin.


```

#### Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A list of initial checks and how you'd envision they'd work would be helpful context here - especially for things like binary version checks where many developers might not have access to things like node debugging 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right that depending on the user's permissions these checks may fail. maybe we can have a check to verify permissions before actually running the checks?

also added this info with current list of checks in SKIP doc.

#-------------------------------------

✓ Containerd version is supported
✓ Containerd shim is installed and configured
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check if the spin app itself is compatible with the shim? Say trigger type isn't supported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is possible but, at this moment, these checks are not specific to any particular spin app. but seems like something that can be useful.

Signed-off-by: Rajat Jindal <[email protected]>
@rajatjindal
Copy link
Member Author

Hi @kate-goldenring @endocrimes, how do you feel about adding this to spinkube plugin?

I think overtime (with support from community), this could become a useful tool for verifying common problems in spinkube setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants