Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show what dep brought in a dep, also the path to it #185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DarthHater
Copy link
Member

To help devs figure out how to remediate, it was suggested to add the:

  • list of deps that require the dep
  • the path to the dep

This gives a developer a lot of information to go on to figure out why something was brought in.

This pull request makes the following changes:

  • Adds fields for what required a dependency, populates them as we parse the list from read-installed
  • Adds a field for the realPath to the dependency, populates it
  • Passes both the read-installed coordinates and ossindexserverresults to Audit, and merges them
  • Outputs the dependency information:

Screen Shot 2020-03-19 at 12 01 47 PM

cc @bhamail / @DarthHater / @allenhsieh / @ken-duck

Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I added some unit tests in a separate PR. Please give that PR a quick look.

I'd be happy to have any feedback on that PR. Also, would like to merge that PR either to this PR or later to master.

@@ -28,7 +28,7 @@ const oldWrite = process.stdout.write;

const doAuditOSSIndex = (results: OssIndexServerResult[]): boolean => {
process.stdout.write = write;
const auditResult = auditOSSIndex.auditResults(results);
const auditResult = auditOSSIndex.auditResults(results, []);
Copy link
Contributor

@bhamail bhamail Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, to assist myself in collecting a clue, I added some unit tests around this here.

Base automatically changed from master to main February 3, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants