Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback constraints in compareAppliedTypeParamRef #22339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rollback constraints in compareAppliedTypeParamRef #22339

wants to merge 1 commit into from
+49 −2

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jan 10, 2025 •
edited
Loading

This PR adds a rollbackConstraintsUnless in compareAppliedTypeParamRef. It is required in case the call to directionalIsSubType introduces constraints and the call to directionalRecur returns false.

Fixes #20519

@mbovel mbovel requested a review from smarter January 10, 2025 16:36
@mbovel mbovel mentioned this pull request Jan 10, 2025
Open
@mbovel mbovel added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter Awaiting requested review from smarter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing given instance for EitherT using type alias
1 participant
@mbovel