Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for primitive data types in responses #945

Conversation

gregg-platogo
Copy link
Contributor

@gregg-platogo gregg-platogo commented Nov 22, 2024

Closes #902

@pablomg92z is this something that you had in mind?

@gregg-platogo gregg-platogo force-pushed the feature/add-support-for-primitive-data-types-in-response branch 8 times, most recently from 300572e to 525bbde Compare November 22, 2024 11:30
@gregg-platogo gregg-platogo force-pushed the feature/add-support-for-primitive-data-types-in-response branch from 525bbde to c54ed8f Compare November 22, 2024 11:33
@gregg-platogo gregg-platogo marked this pull request as ready for review November 22, 2024 11:35
@gregg-platogo
Copy link
Contributor Author

@dblock @padde any chance this gets merged?

@dblock
Copy link
Member

dblock commented Jan 3, 2025

We used to have @LeFnord around here who was actively maintaining the code, let's see if he's around? Otherwise I will take a look.

@LeFnord
Copy link
Member

LeFnord commented Jan 3, 2025

will have a look on it in the evenening

@LeFnord
Copy link
Member

LeFnord commented Jan 4, 2025

thanks @gregg-platogo … please add a CHANGELOG entry, so this welcome enhancement can be released

@gregg-platogo
Copy link
Contributor Author

thanks @gregg-platogo … please add a CHANGELOG entry, so this welcome enhancement can be released

@LeFnord done

@gregg-platogo
Copy link
Contributor Author

Looks like some unrelated tests are failing that don't fail on my machine (the best excuse always haha). I ran the suit on 3.3 and then later on on 3.1 on my local machine.

When I try it on 3.0 I can't go through bundle install:

bundle install
Fetching gem metadata from http://rubygems.org/.......
Fetching https://github.com/ruby-grape/grape-swagger-entity
activesupport-8.0.0 requires ruby version >= 3.2.0, which is incompatible with the current version, ruby 3.0.6p216

3.0 is anyways EOL according to Ruby Maintenance. Maybe it makes sense to drop the support unless you've done it already.

@LeFnord
Copy link
Member

LeFnord commented Jan 7, 2025

thanks @gregg-platogo … will merge it, and having an eye on the specs

@LeFnord LeFnord merged commit 7c74647 into ruby-grape:master Jan 7, 2025
1 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for primitive data types in responses
3 participants