-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for primitive data types in responses #945
Add support for primitive data types in responses #945
Conversation
300572e
to
525bbde
Compare
525bbde
to
c54ed8f
Compare
We used to have @LeFnord around here who was actively maintaining the code, let's see if he's around? Otherwise I will take a look. |
will have a look on it in the evenening |
thanks @gregg-platogo … please add a CHANGELOG entry, so this welcome enhancement can be released |
@LeFnord done |
Looks like some unrelated tests are failing that don't fail on my machine (the best excuse always haha). I ran the suit on 3.3 and then later on on 3.1 on my local machine. When I try it on 3.0 I can't go through
3.0 is anyways EOL according to Ruby Maintenance. Maybe it makes sense to drop the support unless you've done it already. |
thanks @gregg-platogo … will merge it, and having an eye on the specs |
Closes #902
@pablomg92z is this something that you had in mind?