Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex to allow intermediate periods in package names #110

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

xuanxu
Copy link
Collaborator

@xuanxu xuanxu commented Jan 23, 2025

This PR updated the regex for the approve command to allow names like package.name

Closes #109

Copy link
Collaborator Author

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge yet, test are coming...

@mpadge
Copy link
Collaborator

mpadge commented Jan 23, 2025

Thanks @xuanxu, but doesn't that then allow anything between words? Perhaps more importantly, it doesn't seem to work on https://rubular.com/ ... ❓

@xuanxu
Copy link
Collaborator Author

xuanxu commented Jan 23, 2025

@mpadge I've updated the regex to not allow spaces in the name. This is ready to merge now.
It seems to work on Rubular, what strings are you trying?

rubular

@xuanxu
Copy link
Collaborator Author

xuanxu commented Jan 23, 2025

but doesn't that then allow anything between words?

Do you mean the * character? That's a repetition indicator for the previous [...] block, it means "zero or more times"

@mpadge
Copy link
Collaborator

mpadge commented Jan 23, 2025

yeah, right, all good then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants