Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Sidekiq->SSL->Redis #107

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Configure Sidekiq->SSL->Redis #107

merged 1 commit into from
Oct 24, 2024

Conversation

xuanxu
Copy link
Collaborator

@xuanxu xuanxu commented Oct 24, 2024

This PR should fix the error caused by the update of the Heroku SSL certificate.

https://devcenter.heroku.com/articles/connecting-heroku-redis#connecting-from-sidekiq

@xuanxu xuanxu requested review from mpadge and maelle October 24, 2024 17:25
Copy link
Collaborator

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks so much!

@mpadge mpadge merged commit b4df167 into ropensci Oct 24, 2024
10 checks passed
@xuanxu xuanxu deleted the redis-ssl-config branch October 25, 2024 07:30
@mpadge
Copy link
Collaborator

mpadge commented Oct 25, 2024

@xuanxu That didn't fix it, unfortunately. It still errors, but now somewhat more specifically. The service errors when starting up because of this:
image
Then after all the lines starting redis-client, connection_pool, and sidekiq, it ends with:
image
It eventually starts, but then actual requests for external services trigger this:
image
... and so ultimately fail

@xuanxu
Copy link
Collaborator Author

xuanxu commented Oct 25, 2024

@mpadge that's weird, are you sure the last commit was deployed?

@mpadge
Copy link
Collaborator

mpadge commented Oct 25, 2024

Yep:
image

@xuanxu
Copy link
Collaborator Author

xuanxu commented Oct 25, 2024

That looks like a previous deployment from when I merged main into ropensci, last commit should be b4df1679

@mpadge
Copy link
Collaborator

mpadge commented Oct 25, 2024

Aha. @maelle and I couldn't figure out yesterday how to trigger a deployment from the web interface. Any tips there?

@xuanxu
Copy link
Collaborator Author

xuanxu commented Oct 25, 2024

In the "Deploy" tab should be a section for "Manual deploys" at the bottom of the page. Just enter the name of the branch (in this case 'ropensci') and click the "Deploy branch" button.

@mpadge
Copy link
Collaborator

mpadge commented Oct 25, 2024

Yeah, that's what we tried, but just get "Item could not be created: Unauthorized". I think "ropensci" is just the name of the GitHub branch, but it's something else on Heroku?

@xuanxu
Copy link
Collaborator Author

xuanxu commented Oct 25, 2024

No, there is nothing else, the name of the GitHub branch is enough. I have deployed that way sometimes without problems.

I guess you don't have permissions to deploy. The owner have to add you as collaborator. You can see who the owner is in the "Access" tab.
In any case I could do the deployment this evening from my home laptop.

@mpadge
Copy link
Collaborator

mpadge commented Oct 25, 2024

I found out why - the app was connected to GitHub via @maelle's GitHub login, so only she can deploy. Seems there's no way to allow multiple people to deploy that way. And that means we'll have to just wait until auto-deploy tomorrow. If you hear nothing further from me here, it means that everything is working again. Thanks for your help!

@xuanxu
Copy link
Collaborator Author

xuanxu commented Oct 26, 2024

ropensci branch deployed! 🚀

@mpadge
Copy link
Collaborator

mpadge commented Oct 26, 2024

And it works again! Thanks! and ping @maelle with the good news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants