Migrate from docker to composite run actions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action It should be able to reuse the go build cache and share the same build context/environment by using the same default workspace instead of using Docker. It should resolve an issue such as #21 as well.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| func unused(unusedParam int) error { | ||
| func unused1(unusedParam int) error { |
There was a problem hiding this comment.
[golangci-lint-github-pr-review] reported by reviewdog 🐶
unused1 is unused (deadcode)
| x += 1 | ||
| fmt.Sprintf("%d") | ||
|
|
||
| os.Open("main.go") | ||
| os.Open("main1.go") |
There was a problem hiding this comment.
[golangci-lint-github-pr-review] reported by reviewdog 🐶
Error return value of os.Open is not checked (errcheck)
haya14busa
force-pushed
the
composite-run
branch
from
057096f to
45188bf
Compare
haya14busa
force-pushed
the
composite-run
branch
from
45188bf to
8754127
Compare
|
This PR improves a whole action speed as well. 30s -> 6s Before:
After:
|
Vlaaaaaaad
approved these changes
Aug 15, 2020
| PATH="${TEMP_PATH}:$PATH" | ||
|
|
||
| echo '::group::🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog' | ||
| curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b "${TEMP_PATH}" "${REVIEWDOG_VERSION}" 2>&1 |
There was a problem hiding this comment.
The install script picks the version to install based on the OS, so an ARM-based or Windows-based runner would get the expected version for their system. Nice!
shogo82148
added a commit
to shogo82148/aws-xray-yasdk-go
that referenced
this pull request
Aug 16, 2020
|
Thank you for your review! |
|
🚀 [bumpr] Bumped! New version:v1.11.0 Changes:v1.10.1...v1.11.0 |
This was referenced Aug 16, 2020
Merged
This was referenced Aug 30, 2020
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action
It should be able to reuse the go build cache and share the same build
context/environment by using the same default workspace instead of using Docker.
It should resolve an issue such as #21 as well.