AST: use inline record for Ptyp_arrow. #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
typ-arrow-inline-record
branch
from
276b975 to
30b0d78
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 30b0d78 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.210543746666666 ms |
2.10057036 ms |
1.05 |
Print Napkinscript.res - time/run |
81.68034058666667 ms |
77.00100409999999 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
reviewed
Jan 17, 2025
analysis/src/SignatureHelp.ml
Outdated
| Ptyp_arrow | ||
| { | ||
| lbl = argumentLabel; | ||
| typ1 = argumentTypeExpr; |
There was a problem hiding this comment.
Should we maybe use more descriptive names than typ1 and typ2?
Something like argument_type and return_type (or arg_typ and ret_typ or similar)?
There was a problem hiding this comment.
That'd be a good addition indeed.
There was a problem hiding this comment.
The fact that they are types is redundant, so typ1 and typ2 convey very little information.
arg and ret could work well.
cristianoc
force-pushed
the
typ-arrow-inline-record
branch
from
30b0d78 to
b3ce244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.