Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add by_semester method, for the 6-month intervals of the year #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

morellan
Copy link

@morellan morellan commented Aug 1, 2020

I'm using this extra method to check if something happened in the first half or second half of the year, I hope this could be useful for others.

@johnnyshields
Copy link
Collaborator

johnnyshields commented Aug 1, 2020

Hi, this looks fine to merge, however, can you first help fix the failing Travis tests? (I realize they aren't caused by your PR)

@morellan
Copy link
Author

morellan commented Aug 1, 2020

Happy to help, but I'm not sure where to start since most of the errors are caused by some problem in the CI

$ mysql -e 'create database by_star_test;'
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
The command "mysql -e 'create database by_star_test;'" failed and exited with 1 during .

@johnnyshields
Copy link
Collaborator

Thanks! Will merge when CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants