Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move wdh.app to new section #2246

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

wdhdev
Copy link
Contributor

@wdhdev wdhdev commented Nov 8, 2024

Simply moving the domain wdh.app to a new section.

Reason for move is the domain is not really associated with Harrison Network.

The email address is a personal one, as the section is a personal section.

Updated _psl TXT record:

$ dig +short TXT _psl.wdh.app
"https://github.com/publicsuffix/list/pull/2246"

All tests passed.

@simon-friedberger
Copy link
Contributor

I'm not sure if we should do this. Supporting personal sections sounds like it would prompt a lot of questions. And this doesn't have the PR template filled out. And what are we really gaining by splitting entries that are both effectively you?

@wdhdev
Copy link
Contributor Author

wdhdev commented Nov 8, 2024

I should clarify, it's run by myself as an individual, however not under Harrison Network which would more clarify as a 'business'. We could technically call it a 'sole trader' section.

This PR is partially reverting #2183.

There seem to be at least one existing personal section (assuming it counts as a personal section):
The Lõhmus Family: https://github.com/publicsuffix/list/blob/main/public_suffix_list.dat#L14120

In the end, it's not a absolute requirement, feel free to close if you don't think it would fit.

@simon-friedberger
Copy link
Contributor

I am sure there are more I am just not sure we should be reinforcing it. I'll leave it up to you.

@wdhdev
Copy link
Contributor Author

wdhdev commented Nov 8, 2024

I'd personally like to keep them separate, as wdh.app is not under Harrison Network.

@simon-friedberger simon-friedberger merged commit 2733c1c into publicsuffix:main Nov 8, 2024
2 checks passed
@wdhdev wdhdev deleted the patch-1 branch November 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants