Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Table(#17062) | Adding custom sorticon should replace default sorticon. #17281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yxlim-dickson
Copy link

@yxlim-dickson yxlim-dickson commented Jan 3, 2025

Fixes

Changed operator to hide default if ng-template with #sorticon OR pTemplate="sorticon" templates are provided in the component.

This is an enhancement of the fix for issue #17062

As the previous fix requires the both the template ref and ptemplate to be provided in order to hide the default sort icons.

<ng-template #sorticon pTemplate="sorticon">
...
</ng-template>

Changed operator to hide default if ng-template with  `#sorticon` OR `pTemplate="sorticon"` templates are provided in the component.
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:45am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:45am

Copy link

vercel bot commented Jan 3, 2025

@yxlim-dickson is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@yxlim-dickson yxlim-dickson changed the title Fix: Table | Adding custom sorticon should replace default sorticon. Fix: Table(#17062) | Adding custom sorticon should replace default sorticon. Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant