Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove the variable txn_scope #58839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jan 9, 2025

What problem does this PR solve?

Issue Number: ref #58838

Problem Summary:

What changed and how does it work?

Remove the variable txn_scope

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels Jan 9, 2025
@ekexium ekexium changed the title remove the variable txn_scope *:remove the variable txn_scope Jan 9, 2025
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2025
@ekexium ekexium changed the title *:remove the variable txn_scope *: remove the variable txn_scope Jan 9, 2025
Copy link

tiprow bot commented Jan 9, 2025

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1141%. Comparing base (b22555b) to head (3e8e5c0).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58839        +/-   ##
================================================
+ Coverage   73.1419%   75.1141%   +1.9722%     
================================================
  Files          1677       1723        +46     
  Lines        463823     474282     +10459     
================================================
+ Hits         339249     356253     +17004     
+ Misses       103716      95804      -7912     
- Partials      20858      22225      +1367     
Flag Coverage Δ
integration 48.9844% <ø> (?)
unit 72.4802% <ø> (+0.1390%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6494% <ø> (+15.9313%) ⬆️

@ekexium ekexium force-pushed the remove-txn-scope-variable branch from ab66aec to 5bb3b68 Compare January 10, 2025 03:19
@ekexium ekexium force-pushed the remove-txn-scope-variable branch from 5bb3b68 to 3e8e5c0 Compare January 10, 2025 03:38
@ekexium ekexium requested a review from joey-yez January 10, 2025 03:38
@cfzjywxk cfzjywxk requested review from you06 and crazycs520 January 13, 2025 02:03
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 13, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
Copy link

ti-chi-bot bot commented Jan 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 02:04:24.643833377 +0000 UTC m=+751207.932665083: ☑️ agreed by cfzjywxk.
  • 2025-01-13 03:43:25.289604243 +0000 UTC m=+757148.578435947: ☑️ agreed by crazycs520.

@ekexium
Copy link
Member Author

ekexium commented Jan 13, 2025

/retest

Copy link

tiprow bot commented Jan 13, 2025

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium ekexium requested review from XuHuaiyu and tangenta January 13, 2025 07:03
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 13, 2025
Copy link

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, joey-yez, tangenta
Once this PR has been reviewed and has the lgtm label, please assign xuhuaiyu, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 15, 2025

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants