Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release: v3.1.2 #814

Merged
merged 34 commits into from
Jan 27, 2025
Merged

Next Release: v3.1.2 #814

merged 34 commits into from
Jan 27, 2025

Conversation

aclark02-arcus
Copy link
Collaborator

@aclark02-arcus aclark02-arcus commented Aug 5, 2024

For reference, here is the Cutting a new release wiki. This release is comprised of all patch updates, hence the increment from v3.1.1 to v3.1.2:

  • Open hyperlinks in a new tab from cards.
  • Fix bug causing app to crash with ELSE condition in rules
  • Add inherits to list of used configs
  • Incorporate bug fix for dependency assessment from riskmetric repo
  • bug fix for when to display Decision Automation header and horizontal line on Upload pkgs tab

I also pulled all changes into a new branch called demo-shinyapps.io-v312, which is deployed here:

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (b04110a) to head (b582c47).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
R/mod_decision_automation_utils.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   81.92%   81.97%   +0.05%     
==========================================
  Files          36       36              
  Lines        6711     6714       +3     
==========================================
+ Hits         5498     5504       +6     
+ Misses       1213     1210       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aclark02-arcus aclark02-arcus changed the title Next Release (post v3.1.1) Next Release:v3.1.2 Jan 25, 2025
@aclark02-arcus aclark02-arcus changed the title Next Release:v3.1.2 Next Release: v3.1.2 Jan 25, 2025
@aclark02-arcus
Copy link
Collaborator Author

Converting to draft until #838 is merged.

@aclark02-arcus aclark02-arcus marked this pull request as draft January 27, 2025 12:54
Fix bug where `Decision Automation` header isn't displaying for "less privileged" roles
@aclark02-arcus aclark02-arcus marked this pull request as ready for review January 27, 2025 14:06
Copy link
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclark02-arcus aclark02-arcus removed the request for review from Jeff-Thompson12 January 27, 2025 20:11
@aclark02-arcus aclark02-arcus merged commit 7165440 into master Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants