This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
feat: Attachment of files as block to documents using s3 #624
+472
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added file upload feature. (outline commit is outline/outline#2936)
It is almost same with what chanchadsahi, FeralMib did(#280 , #603 ).
The difference is that it is made form of a notice block.
And, I need some help. There are bad code here.
parseMarkdown() { return { block: "container_file", getAttrs: token => { const file_regex = /\[(?<alt>[^]*?)\]\((?<filename>[^]*?)\)/g; const result = file_regex.exec(token.info); return { src: result? result[2] : null, alt: result? result[1] : null, }; }, }; }
I want to place src(file url) and title variable in attributes but, I don't know how to do it.
Can anyone help this?