gping: update to 1.19.0 #25687
Draft
gping: update to 1.19.0 #25687
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - rewrite of internal pinger library - dependency updates Signed-off-by: Jonas Jelonek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: aarch64_cortex-a53 (BananaPi R64), OpenWrt snapshot
Run tested: aarch64_cortex-a53 (BananaPi R64), OpenWrt snapshot, ping test
Description:
compile-test: fine, run-test: fails for ping
Due to the rewrite of the internal pinger library, gping now uses a default interval of 0.2 seconds for ping. Before, no specific interval was used. While this works fine for Alpines BusyBox, which upstream explicitly supports, it doesn't on OpenWrt because the BusyBox option
FRACTIONAL_DURATIONis disabled by default.Not sure how to fix this, I can think of three solutions:
FLOAT_DURATIONtoyes+@BUSYBOX_CUSTOM +@BUSYBOX_CONFIG_FLOAT_DURATIONto package DEPENDS. works, but requiresBUSYBOX_CUSTOM. However, this doesn't seem to me like a good solution.No proper release notes available.
changes: