Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema content-type fix #3474

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Schema content-type fix #3474

merged 2 commits into from
Nov 2, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 2, 2023 •
edited
Loading

@chalin chalin requested a review from a team November 2, 2023 11:50
This was referenced Nov 2, 2023
Closed
Open
tigrannajaryan
tigrannajaryan approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just a comment on the media type string to use.

netlify.toml Outdated Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-schema-type-fix-2023-11-02 branch from 2ca14f6 to 968b6b5 Compare November 2, 2023 14:32
@chalin chalin merged commit e35ce45 into open-telemetry:main Nov 2, 2023
12 checks passed
@chalin chalin deleted the chalin-im-schema-type-fix-2023-11-02 branch November 2, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that schema files are served with content-type application/yaml
2 participants
@chalin @tigrannajaryan