-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Remove the in-development isolating log record processor #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Nov 19, 2024
cijothomas
approved these changes
Nov 19, 2024
reyang
approved these changes
Nov 19, 2024
MrAlias
approved these changes
Nov 25, 2024
trask
approved these changes
Nov 25, 2024
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@carlosalberto, I guess this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the in-development isolating log record processor introduced in #4062 by myself.
Reasons
According to the most recent discussions regarding
Enabled
SDK implementation (see: #4207) there looks to be a tendency to lean towards simplifying the SDK.The current preference is that the users should use the collector for setting up multiple log processing pipelines. E.g.
The users can still create workarounds e.g. by deep cloning of a
ReadWriteLogRecord
and make log record processor decorators.There is no need to deprecate the isolating processor as AFAIK nobody has implemented it (there was only a prototype for OTel Go: open-telemetry/opentelemetry-go-contrib#5861).