Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Esbuild plugin diag channels #2640

Draft
wants to merge 111 commits into
base: main
Choose a base branch
from

Conversation

drewcorlin1
Copy link
Contributor

@drewcorlin1 drewcorlin1 commented Jan 12, 2025

Which problem is this PR solving?

Providing an esbuild plugin for auto instrumentation open-telemetry/opentelemetry-js#4174. Depdendent on open-telemetry/opentelemetry-js#5334

Short description of the changes

Diag channels based alternative to #1856.

@github-actions github-actions bot requested a review from trentm January 12, 2025 17:28
@drewcorlin1 drewcorlin1 changed the title Esbuild plugin diag channels feat: Esbuild plugin diag channels Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 92.24138% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (c2ad0af) to head (b3f9bd3).

Files with missing lines Patch % Lines
packages/esbuild-plugin-node/src/config/main.ts 77.27% 5 Missing ⚠️
packages/esbuild-plugin-node/src/plugin.ts 95.60% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2640    +/-   ##
========================================
  Coverage   90.79%   90.80%            
========================================
  Files         169      172     +3     
  Lines        8059     8175   +116     
  Branches     1645     1678    +33     
========================================
+ Hits         7317     7423   +106     
- Misses        742      752    +10     
Files with missing lines Coverage Δ
packages/esbuild-plugin-node/src/common.ts 100.00% <100.00%> (ø)
packages/esbuild-plugin-node/src/plugin.ts 95.60% <95.60%> (ø)
packages/esbuild-plugin-node/src/config/main.ts 77.27% <77.27%> (ø)

... and 1 file with indirect coverage changes

@drewcorlin1
Copy link
Contributor Author

drewcorlin1 commented Jan 12, 2025

Tests are expected to fail in the CI until open-telemetry/opentelemetry-js#5334 is merged. Can confirm new tests added here are working locally with the steps described in the description of that PR

@drewcorlin1 drewcorlin1 marked this pull request as draft January 12, 2025 17:46
@drewcorlin1
Copy link
Contributor Author

Marking as draft until open-telemetry/opentelemetry-js#5334 is reviewed and merged, as the CI tests will fail until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:auto-configuration-propagators pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:propagation-utils pkg:propagator-aws-xray pkg:propagator-aws-xray-lambda pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sampler-aws-xray pkg:test-utils pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.