Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @opentelemetry/semantic-conventions to 1.28 #2549

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 25, 2024

Which problem is this PR solving?

Short description of the changes

  • Updates @opentelemetry/semantic-conventions to 1.28

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (2f5d1de) to head (9f2acaf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2549   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@@ -71,7 +71,7 @@
"dependencies": {
"@opentelemetry/core": "^1.26.0",
"@opentelemetry/instrumentation": "^0.55.0",
"@opentelemetry/semantic-conventions": "1.27.0",
"@opentelemetry/semantic-conventions": "^1.28.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be discussed.
Over in open-telemetry/opentelemetry-js#5182 we are discussing the advice/recommendations/policy for using the "incubating" entry-point of the semconv JS package.

The rough concensus is that we will pin the semconv dep for a package when it is using the incubating entry-point, because in general there can be (hopefully rare) breaking changes in the incubating entry-point for a minor version release.

That's the reason this particular dep was pinned.

Currently the only packages in the contrib repo using the incubating endpoint are instrumentation-pg and intrumentation-aws-lambda. The latter isn't pinning the dep, mainly I assume because we are still working out how we want to handle the semconv dep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned in 9f2acaf (#2549)

@trivikr trivikr force-pushed the bump-semantic-conventions branch from aaabf23 to 9f2acaf Compare November 28, 2024 00:21
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Nov 30, 2024
This adds a lint step that checks that packages in the workspace
are following our 'rule' that uses of the semconv pkg 'incubating'
entry-point should *pin* the '@opentelemetry/semantic-conventions'
dep. This is because (though rare) the incubating/unstable
semconv exports can have breaking changes in minors.

Refs: open-telemetry#2549 (comment)
Refs: open-telemetry/opentelemetry-js#5182
@trivikr
Copy link
Contributor Author

trivikr commented Dec 2, 2024

Moving to draft. It can be rebased after #2569 is merged.

@trivikr trivikr marked this pull request as draft December 2, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.