-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): Relax go minor version requirement #6595
fix(deps): Relax go minor version requirement #6595
Conversation
For reference: open-telemetry/opentelemetry-go#6073 (you may need to bump OTel Go to at least open-telemetry/opentelemetry-go@0b00bfb) |
Nope, running
Added. |
The deps that are preventing other packages from using go1.22.0 are in go.opentelemetry.io/otel:
I think they can be relaxed by updating the opentelemetry-go repo first. |
See:
|
@pellared, should we keep this PR on hold till the next |
I would upgrade those dependencies on |
@MrAlias I've bumped only the dependencies that were needed to relax the go version. PTAL. |
@arjan-bal what about |
The minor version in that module is due to the following dependencies:
|
Gotcha, thanks for tracking that down. I think the |
@arjan-bal, thank you for your contribution 🥇 |
grpc-go 1.68.0 added the go minor version when bumping the go version from
go1.21
togo1.22
. Due to user feedback, gRPC Go decided to drop the Go minor version in grpc/grpc-go#7831 which was part of grpc-go 1.68.1. Quoting this comment from @ash2k:When the grpc-go version in opentelemetry-go-contrib was bumped, the go minor version got added to this repo's mod files: #6306
When grpc-go is bumping the version of go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelg
rpc, the go minor version is getting added again. This PR aims to relax the min version requirement to avoid this.