Add capability for memory and persistent queue to block when add items #12074
+407
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
add-blocking
branch
2 times, most recently
from
07509db to
f66fc54
Compare
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
add-blocking
branch
9 times, most recently
from
6be2329 to
e5ca0d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12074 +/- ##
==========================================
- Coverage 91.68% 91.62% -0.06%
==========================================
Files 455 456 +1
Lines 24039 24086 +47
==========================================
+ Hits 22039 22068 +29
- Misses 1629 1645 +16
- Partials 371 373 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
add-blocking
branch
from
e5ca0d6 to
a4b96ca
Compare
dmitryax
reviewed
Jan 12, 2025
dmitryax
reviewed
Jan 12, 2025
| sq.hasElements.Wait() | ||
| // TODO: Change the Queue interface to return an error to allow distinguish between shutdown and context canceled. | ||
| // Ok to ignore the error, since the context.Background() will never be done. | ||
| _ = sq.hasMoreElements.Wait(context.Background()) |
There was a problem hiding this comment.
Do we need to switch hasMoreElements to the custom cond to resolve the TODO later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is not yet exposed to the user because there is no config available. One option to consider is to add a "blocking" bool in the queue config.
Link to tracking issue
#8122
#10368