Add obs for logs in scraper/scraperhelper #12036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12036 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.02%
==========================================
Files 455 456 +1
Lines 24010 24073 +63
==========================================
+ Hits 22010 22063 +53
- Misses 1629 1638 +9
- Partials 371 372 +1 ☔ View full report in Codecov by Sentry. |
|
@bogdandrutu |
bogdandrutu
reviewed
Jan 10, 2025
| @@ -86,6 +86,12 @@ func (tts *TestTelemetry) CheckReceiverMetrics(protocol string, acceptedMetricPo | |||
| return checkReceiverMetrics(tts.reader, tts.id, protocol, acceptedMetricPoints, droppedMetricPoints) | |||
| } | |||
|
|
|||
| // CheckScraperLogs checks that for the current exported values for logs scraper metrics match given values. | |||
| // Note: SetupTelemetry must be called before this function. | |||
| func (tts *TestTelemetry) CheckScraperLogs(receiver component.ID, scraper component.ID, scrapedLogRecords, erroredLogRecords int64) error { | |||
There was a problem hiding this comment.
I am actually planning to remove the other one. So I don't think this is necessary.
| @@ -15,6 +15,13 @@ import ( | |||
| "go.opentelemetry.io/collector/component" | |||
| ) | |||
|
|
|||
| func checkScraperLogs(reader *sdkmetric.ManualReader, receiver component.ID, scraper component.ID, scrapedLogRecords, erroredLogRecords int64) error { | |||
| switch { | ||
| case params[i].err == nil: | ||
| scrapedLogRecords += params[i].items | ||
| require.Contains(t, span.Attributes(), attribute.KeyValue{Key: scrapedLogRecordsKey, Value: attribute.Int64Value(int64(params[i].items))}) |
There was a problem hiding this comment.
Use attribute.Int64 instead of manually construct the key and the value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds obs for logs in scraper/scraperhelper, also introduced new metrics for scraping logs.
Link to tracking issue
Relates to #11238
Testing
Added
Documentation
Added